Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Client library embedded into iframe, additional features #1

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Client library embedded into iframe, additional features #1

wants to merge 4 commits into from

Conversation

ctpahhik
Copy link

Client library embedded into iframe for those who doesn't want to depend on external services.
Ability to stop accepting new connections for graceful shutdown.

@cgbystrom
Copy link
Owner

Thanks for submitting a PR!

Sorry for the delayed response. I wrote some comments on your commits.
If you can address them I would be happy to accept your pull request!

@ctpahhik
Copy link
Author

Hi
Thank you for comments.
Removed SNAPSHOT and OrderedMemoryAwareThreadPoolExecutor are pulled by mistake, it was added for our internal purposes. Will remove it.
Old way to create SourceRouter should be left as is, I'll recheck it. New constructor's parameter is InputStream.
btw. it would be great if you describe reasons you mentioned to use client lib as external resource in javadoc.

will apply your comments asap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ctpahhik @cgbystrom